codyml commented on code in PR #20902:
URL: https://github.com/apache/superset/pull/20902#discussion_r964467771
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.jsx:
##########
@@ -337,7 +375,7 @@ function ExploreViewContainer(props) {
}
function toggleModal() {
- setShowingModal(!showingModal);
+ props.actions.setSaveModalVisible(!props.isSaveModalVisible);
Review Comment:
I don't think we were able to solve it: IIRC it seemed to happen whenever we
tried to send additional Redux actions at the same time as when Explore was
rendering. [Here's the PR](https://github.com/apache/superset/pull/20704) that
would have fixed it if we hadn't reverted the whole thing. Not sure if your
case is similar? I think that also might be why Cypress is failing on yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
