michael-s-molina commented on code in PR #21360: URL: https://github.com/apache/superset/pull/21360#discussion_r965222518
########## superset-frontend/src/components/FaveStar/FaveStar.test.tsx: ########## @@ -26,13 +26,13 @@ jest.mock('src/components/Tooltip', () => ({ Tooltip: (props: any) => <div data-test="tooltip" {...props} />, })); -test('render right content', () => { +it('render right content', async () => { Review Comment: ```suggestion test('render right content', async () => { ``` ########## superset-frontend/src/components/FaveStar/FaveStar.test.tsx: ########## @@ -54,7 +54,7 @@ test('render right content', () => { expect(props.saveFaveStar).toBeCalledWith(props.itemId, false); }); -test('render content on tooltip', () => { +it('render content on tooltip', async () => { Review Comment: ```suggestion test('render content on tooltip', async () => { ``` ########## superset-frontend/src/components/FaveStar/FaveStar.test.tsx: ########## @@ -75,7 +75,7 @@ test('render content on tooltip', () => { expect(screen.getByRole('button')).toBeInTheDocument(); }); -test('Call fetchFaveStar only on the first render', () => { +it('Call fetchFaveStar only on the first render', async () => { Review Comment: ```suggestion test('Call fetchFaveStar only on the first render', async () => { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org