codyml opened a new pull request, #21484: URL: https://github.com/apache/superset/pull/21484
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> In #21315, I refactored shared controls so feature flag checking for drag and drop was done in React render instead on module load. As part of that, I modified the config object's `options` property to be an array instead of an object for some DnD shared controls, because non-DnD versions expected an array and I wanted to merge DnD and non-DnD config objects. But, I missed a place where a `visibility` function expected an object, causing the Time Grain control to not appear when `GENERIC_CHART_AXES` is enabled. This PR fixes that issue. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> **Before:**  **After:**  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Ensure that `Time Grain` appears for charts supporting generic X-axis when `GENERIC_CHART_AXES` is enabled. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Required feature flags: `GENERIC_CHART_AXES` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
