benjamin-mueller commented on issue #18634:
URL: https://github.com/apache/superset/issues/18634#issuecomment-1249095958

   The role management is done somewhere else, as mentioned in the parent 
function
   
   ```
   def raise_for_dashboard_access(self, dashboard: "Dashboard") -> None:
           """
           Raise an exception if the user cannot access the dashboard.
           This does not check for the required role/permission pairs,
           it only concerns itself with entity relationships.
           :param dashboard: Dashboard the user wants access to
           :raises DashboardAccessDeniedError: If the user cannot access the 
resource
           """
   ```
   
   
https://github.com/apache/superset/blob/2d16100dbcc1d12d4c077b109f80ade53785077e/superset/security/manager.py#L1916
   
   We tested it on our systems with roles assigned and it worked as expected, 
sorry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to