zhaorui2022 opened a new pull request, #21561: URL: https://github.com/apache/superset/pull/21561
### SUMMARY set up email report button should be enabled for users who have "menu_access on Manage" permission. However, the previous implementation only checks if the first role associated with the user has the required permission, not the others. For those who were granted with the permission through other roles, they won't be able to see the button. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before <img width="285" alt="Screen Shot 2022-09-22 at 3 57 51 PM" src="https://user-images.githubusercontent.com/105950525/191872445-00ef1295-e539-4b88-8d29-22785bbea7bf.png";> After  ### TESTING INSTRUCTIONS I have tested with our own superset stack. With the same set of permissions, before the change, the user couldn't see the button. But after the change, the button shows up. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: https://github.com/apache/superset/issues/21559 - [X] Required feature flags: ALERT_REPORTS needs to be enabled - [X] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/105950525/191872445-00ef1295-e539-4b88-8d29-22785bbea7bf.png"](https://user-images.githubusercontent.com/105950525/191872445-00ef1295-e539-4b88-8d29-22785bbea7bf.png"){kind=link}
