villebro commented on code in PR #21581:
URL: https://github.com/apache/superset/pull/21581#discussion_r979986274


##########
setup.py:
##########
@@ -117,7 +117,7 @@ def get_git_sha() -> str:
         "slackclient==2.5.0",  # PINNED! slack changes file upload api in the 
future versions
         "sqlalchemy>=1.4, <2",
         "sqlalchemy-utils>=0.38.3, <0.39",
-        "sqlparse==0.3.0",  # PINNED! see 
https://github.com/andialbrecht/sqlparse/issues/562
+        "sqlparse>=0.4.3",

Review Comment:
   To minimize risk of breakage caused by backwards incompatible changes:
   ```suggestion
           "sqlparse>=0.4.3, <0.5",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to