jayakrishnankk commented on code in PR #21070:
URL: https://github.com/apache/superset/pull/21070#discussion_r984043584
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -34,6 +37,11 @@ export type UiConfigType = {
hideTitle?: boolean
hideTab?: boolean
hideChartControls?: boolean
+ filters?: {
+ [key: string]: boolean | undefined
+ visible?: boolean
+ expanded?: boolean
Review Comment:
@jileeon - considering `DASHBOARD_UI_FILTER_CONFIG_URL_PARAM_KEY` only has 2
keys namely `visible` and `expanded` and line number 115 does
`DASHBOARD_UI_FILTER_CONFIG_URL_PARAM_KEY[key]=filterConfig[key]`, i don't
understand why there is a need for line number 41 (`[key: string]: boolean |
undefined`) in the code.
I found this code while I was trying to add some additional capability add
some extra url parameters to the embedded superset. But I don't want to add
that code if the functionality already exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
