zhaoyongjie commented on PR #21632: URL: https://github.com/apache/superset/pull/21632#issuecomment-1264868521
> > LGTM, work as expected. One suggestion for this part is that should disable the `Run` button when the selection area is 1) empty or 2) beginning a comment(--) of SQL and only 1 line. > > selection.in.SQLLab.mov > > @zhaoyongjie I made changes for this improvement > run.selection.mov Thanks for tackling the long-term UX issue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
