codyml commented on code in PR #21351:
URL: https://github.com/apache/superset/pull/21351#discussion_r989572253
##########
superset-frontend/src/components/Chart/ChartRenderer.jsx:
##########
@@ -285,47 +296,55 @@ class ChartRenderer extends React.Component {
);
}
+ // Check for Behavior.DRILL_TO_DETAIL to tell if chart can receive Drill
to
+ // Detail props or if it'll cause side-effects (e.g. excessive
re-renders).
Review Comment:
I think it's the same thing that's going on with World Map, where the React
wrapper re-renders its contents whenever there's a prop change, so if we pass
`inContextMenu` it causes the visualization to flash when you right-click. You
can see it happen if you add `Behavior.DRILL_TO_DETAIL` to one of the legacy
charts (e.g. NVD3 Bar), or if you remove the behavior from World Map the
flashing should stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
