mayurnewase commented on code in PR #21729:
URL: https://github.com/apache/superset/pull/21729#discussion_r990675576
##########
superset/connectors/sqla/models.py:
##########
@@ -1438,15 +1438,24 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
select_exprs.append(outer)
elif columns:
for selected in columns:
+ if is_adhoc_column(selected):
+ sql = selected.get("sqlExpression") or ""
Review Comment:
@zhaoyongjie now as `sqlExpression` in `AdhocColumn` is optional, I need to
put `or ""` to tell mypy it's a string, is this correct way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
