eschutho commented on code in PR #21486:
URL: https://github.com/apache/superset/pull/21486#discussion_r990722544
##########
tests/unit_tests/conftest.py:
##########
@@ -82,6 +82,11 @@ def app() -> Iterator[SupersetApp]:
app.config["PREVENT_UNSAFE_DB_CONNECTIONS"] = False
app.config["TESTING"] = True
+ # loop over extra configs passed in by tests
+ if request and hasattr(request, "param"):
+ for key, val in request.param.items():
+ app.config[key] = val
+
Review Comment:
I added typing here. Request is a pytest fixture sub request object. So I
can’t change the name of param but agree it would read better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
