justinpark opened a new pull request, #21878:
URL: https://github.com/apache/superset/pull/21878

   ### SUMMARY
   This commit fixes the type of AnnotationLayer to be compatible with 
TableAnnotationLayer
   This will be thrown an error in next typescript version.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   <img width="818" alt="Screen Shot 2022-10-19 at 2 31 09 PM" 
src="https://user-images.githubusercontent.com/1392866/196809128-b2423d24-5f55-4e61-b640-e5edbc04d883.png";>
   
   
   ### TESTING INSTRUCTIONS
   bump up typescript to 4.6.4 and then `npm run type`
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to