zhaoyongjie commented on code in PR #21879: URL: https://github.com/apache/superset/pull/21879#discussion_r1000198331
########## superset/config.py: ########## @@ -153,6 +153,9 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]: SAMPLES_ROW_LIMIT = 1000 # max rows retrieved by filter select auto complete FILTER_SELECT_ROW_LIMIT = 10000 +# default time filter in explore +# values may be "Last day", "Last week", "<ISO date> : now", etc. +DEFAULT_TIME_FILTER = None Review Comment: one nite, we should keep this config as before, the `None` and the `No filter` will generate different time expressions. the `None` will generate ` : today`(col <= today()), and `No filter` will generate ` : `(empty filter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
