villebro commented on code in PR #21931:
URL: https://github.com/apache/superset/pull/21931#discussion_r1007856006
##########
tests/integration_tests/reports/commands_tests.py:
##########
@@ -649,6 +663,65 @@ def test_email_chart_report_schedule(
assert_log(ReportState.SUCCESS)
[email protected](
+ "load_birth_names_dashboard_with_slices",
"create_report_email_chart_alpha_owner"
+)
+@patch("superset.reports.notifications.email.send_email_smtp")
+@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
+def test_email_chart_report_schedule_alpha_owner(
Review Comment:
I broke out `_get_user` into a util called `get_executor` and added a full
set of unit tests on it:
https://github.com/apache/superset/pull/21931/commits/bbda0b606066a55b94fdc1867ec9d3847cdaa276
I must say think the end result looks much better 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
