zhaoyongjie commented on PR #21767: URL: https://github.com/apache/superset/pull/21767#issuecomment-1298804072
> > > Thank you for the great work~ I have a question, it looks like when i use custom sql in filter with time column, time comparison did not support, is this expected? Steps: 1, add a time column to filter 2, use time comparison to define start and end 3, go to time comparison and select compare time > > > > > > Hi @jinghua-qa, the `Time Comparision` + `Custom SQL` doesn't been supported yet. Currently, the `Time Comparision` should with `time range` in the Adhoc filter rather than `Custom SQL`. > > Are we going to support this feature in the future? it looks like when we move the time range to filter, user can use custom sql to support time column as filter, it will be great if we can support that with time comparison. If we want to support `custom SQL` + `Time Comparison`, there are some pre-requirement works, e.g. 1) parsing and validating it. 2) it should contain the start time and end time. This part of the work is completely beyond the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
