Stanhoucke opened a new pull request, #22208: URL: https://github.com/apache/superset/pull/22208
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> For existing dashboards, modifications imported via `/api/v1/assets/import/` are only appended if the modified dashboard contains a new chart. Modifications to dashboards that remove a chart are not implemented when imported through the assets API. This change updates the assets API import method to remove all existing references to chart ids for the imported dashboard(s) before inserting the new chart ids. The change should benefit the management of Superset assets under source control. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Remove a chart from a dashboard: - Export a dashboard and unzip assets bundle. - Remove a chart and all references to it from the exported yaml files - Import modified assets bundle as a zip by posting to `/api/v1/assets/import/` (see https://superset.apache.org/docs/api/#api) - Navigate to the modified dashboard in the Superset UI and observe the deleted chart is no longer visible Add a chart to a dashboard: - In the same dashboard, remove a chart using the UI and save the dashboard - Import the previously exported assets bundle as a zip by posting to `/api/v1/assets/import/` - Navigate to the modified dashboard in the Superset UI and observe the deleted chart is now reinstated ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/22127 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
