justinpark opened a new pull request, #22209: URL: https://github.com/apache/superset/pull/22209
### SUMMARY Related to #20934 change, the following `props.controls[controlName].value` can be undefined when alteredControls are not existed on props.controls. https://github.com/apache/superset/blob/888f43c6ad8444100cdcbf42c2ee0ae4f80c5ea3/superset-frontend/src/explore/components/ControlPanelsContainer.tsx#L278-L283 This commit fixes the following undefined property access error due to this change. ``` react-dom.production.min.js:209 TypeError: Cannot read properties of undefined (reading 'value') at ControlPanelsContainer.tsx:282:39 at Array.forEach (<anonymous>) at ControlPanelsContainer.tsx:280:28 at il (react-dom.production.min.js:211:320) ``` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: <img width="1678" alt="image (9)" src="https://user-images.githubusercontent.com/1392866/203626623-1ccfcfd2-b87c-40aa-9537-53be0ce0df23.png";> After: N/A ### TESTING INSTRUCTIONS - click Create Chart in SQL Lab, it opens the explore view - runs the query by default - that query finished running is when I got this error and the UI broke ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API cc: @ktmud @john-bodley -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1392866/203626623-1ccfcfd2-b87c-40aa-9537-53be0ce0df23.png"](https://user-images.githubusercontent.com/1392866/203626623-1ccfcfd2-b87c-40aa-9537-53be0ce0df23.png"){kind=link}