kgabryje opened a new pull request, #22248: URL: https://github.com/apache/superset/pull/22248
### SUMMARY This PR adds a downgrade migration that removes `filter_bar_orientation` field from dashboard's `json_metadata`. It's related to the horizontal filter bar feature that's currently in development and is locked behind a `HORIZONTAL_FILTER_BAR` feature flag. It's a required cleanup step when downgrading Superset version, because the horizontal filter bar project adds `filter_bar_orientation` field to `DashboardJSONMetadataSchema` schema. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [x] Migration is atomic, supports rollback & is backwards-compatible - [x] Confirm DB migration upgrade and downgrade tested - [x] Runtime estimates and downtime expectations provided ` Current: 0.26 s 10+: 0.40 s 100+: 0.41 s 1000+: 0.25 s ` - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
