eschutho commented on code in PR #21912:
URL: https://github.com/apache/superset/pull/21912#discussion_r1035414183
##########
superset/databases/commands/test_connection.py:
##########
@@ -90,6 +91,14 @@ def run(self) -> None: # pylint: disable=too-many-statements
database.set_sqlalchemy_uri(uri)
database.db_engine_spec.mutate_db_for_connection_test(database)
+ # Generate tunnel if present in the properties
+ ssh_tunnel = None
Review Comment:
nit, but I don't think you need this assignment here. ssh_tunnel will be
None even if the next line evaluates to false. It will assign the value to the
local scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
