khtruong commented on issue #7045: Allow charts to be scrollable
URL: 
https://github.com/apache/incubator-superset/pull/7045#issuecomment-473478937
 
 
   > Historically we've been setting this on the CSS of the charts that are 
expected to overflow. Have you tested that no unwanted scrollbars appears for 
all chart types in all contexts?
   > 
   > To minimize the potential impact here I'd do it only on the CSS of the 
charts that require this.
   > 
   > Is this not working?
   > 
https://github.com/apache-superset/superset-ui-plugins/blob/master/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.css#L20
   
   The div is not assigned a class name for some reason. So then the css rule 
is not applied to this plain div. I will dig into why the div is not getting 
assigned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to