[GitHub] [superset] michael-s-molina commented on pull request #22337: fix: Styling fixes for horizontal filter bar

[GitBox]

michael-s-molina commented on PR #22337:
URL: https://github.com/apache/superset/pull/22337#issuecomment-1339520728

   @kasiazjc @kgabryje What do you think about inverting the positions of the 
empty message and the Add Filters? That way, the gear icon, and Add Filters 
will keep a constant position when interacting with the bar. So with this, we 
would have:
   - A fixed area on the left with a gear icon + Add Filters
   - A dynamic central area where we can add filters or present the empty text
   - A fixed area on the right with the Apply + Clear All buttons
   
   <img width="643" alt="Screen Shot 2022-12-06 at 9 54 38 AM" 
src="https://user-images.githubusercontent.com/70410625/205947879-70f6660a-120f-4337-a6de-89ec65d028fc.png";>
   <img width="515" alt="Screen Shot 2022-12-06 at 10 00 21 AM" 
src="https://user-images.githubusercontent.com/70410625/205947881-c73e474b-88b8-4f3a-aa5c-5bde0e4f4fa2.png";>
   
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org