Antonio-RiveroMartnez commented on code in PR #22066:
URL: https://github.com/apache/superset/pull/22066#discussion_r1041254546
##########
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx:
##########
@@ -1300,7 +1309,7 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
placeholder={t('Time in seconds')}
onChange={onTimeoutVerifyChange}
/>
- <span className="input-label">seconds</span>
+ <span className="input-label">{t('seconds')}</span>
Review Comment:
I totally liked what you did here:
https://github.com/apache/superset/pull/22262/files#diff-bbf91464669d98b9e120f57ce26155804f7238a277fcc30c0d805a943f6c73edR98
, could we do the same for these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
