Antonio-RiveroMartnez opened a new pull request, #22349: URL: https://github.com/apache/superset/pull/22349
### SUMMARY This PR is fixing the wrong error messages we are seeing with BigQuery after we introduced these changes: https://github.com/apache/superset/pull/22024 . Initially we were trying to get rid of `bigquery error:` section in the message, so we decided to split the exception message. However, the engine is NOT adding such section into the message, instead it's just returning: `400 Syntax error: ...` for example, and it's us the ones adding that in this method: `extract_error_message` from the `BaseEngineSpec` class. So, these proposed changes are not splitting the message, just getting the first line (if multiple), and we keep the `bigquery error:` section in it. We could also override the `extract_error_message` in `BigQueryEngineSpec` to remove that section, however, I'd like to be consistent with all our other engines. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before:  After:  ### TESTING INSTRUCTIONS 1. Open SQL Lab and force a Syntax error when querying a BigQuery DB 2. Error message should display properly ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
