eschutho opened a new pull request, #22361:
URL: https://github.com/apache/superset/pull/22361

   ### SUMMARY
   In https://github.com/apache/superset/pull/21573 we added a hook to load the 
driver for the database selected, but it was causing some runtime errors for 
gsheets, so I moved it to the base db connection modal component. 
   
   ### TESTING INSTRUCTIONS
   Opening a db connection modal edit screen for gsheets should work. Also, as 
a side effect, creating saving and editing databases should still work properly 
and should be passing a driver param to the api. 
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to