rusackas commented on PR #21479: URL: https://github.com/apache/superset/pull/21479#issuecomment-1343425478
Most of this seems a-ok! Thanks for the contribution! The vast majority of the `t()` calls seem unobjctionable. There is, however, a fair amount of change in this PR involving Moment and utc timestamps. A description of how that fits in here (and any PR description at all, for that matter) would be helpful. There are also a couple of translated strings in there that look like they might be fairly dynamic in terms of content. We shouldn't use the t() wrapper unless the translated string is static/stable. Also noting that this should close out https://github.com/apache/superset/issues/21200 and this can be done automatically by adding "Fixes: #21200" in your PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
