lyndsiWilliams commented on code in PR #22350:
URL: https://github.com/apache/superset/pull/22350#discussion_r1043914520
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.test.tsx:
##########
@@ -1325,23 +1332,23 @@ describe('DatabaseModal', () => {
...jest.requireActual('src/views/CRUD/hooks'),
useSingleViewResource: jest.fn(),
}));
- const useSingleViewResourceMock = jest.spyOn(
- hooks,
- 'useSingleViewResource',
- );
-
- useSingleViewResourceMock.mockReturnValue({
- state: {
- loading: false,
- resource: null,
- error: { _schema: 'Test Error With Object' },
- },
- fetchResource: jest.fn(),
- createResource: jest.fn(),
- updateResource: jest.fn(),
- clearError: jest.fn(),
- setResource: jest.fn(),
- });
+ // const useSingleViewResourceMock = jest.spyOn(
Review Comment:
These are from a todo from long ago that I forgot about, we can definitely
remove these and come back to it another time 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
