rusackas commented on PR #22367: URL: https://github.com/apache/superset/pull/22367#issuecomment-1347439544
I have to assume there are many other locations in Superset that are exhibiting this inconsistency if they Modal component itself isn't already styled this way. In general, patching up a singular instantiation of something is more difficult to maintain, since the approach will be copied/pasted in numerous locations. Have you tried taking the approach of modifying the Modal component (which is essentially a decorated version of the AntD modal, with a layer of Emotion styling) so that the correct styles can be added at the root, rather than overriding/bypassing things for a singular instance of the modal? CC @michael-s-molina @eric-briscoe @geido in case either of them have looked at the Modal component lately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
