rusackas commented on PR #22107: URL: https://github.com/apache/superset/pull/22107#issuecomment-1350228832
There are a few things from the old chart that aren't supported in this new one • Display of X bounds and Wy bounds (the extent numbers on the axes) • Auto-rotation of axis labels • Axis limit inputs (love 'em or hate 'em) • Series limit (this one seems like it would be important) • Max Bubble Size While I think _most_ people would be fine with _most_ of the above, it might be a bit contentious to call it a drop-in replacement without complete feature parity. We've learned this lesson before and been stuck with difficult reverts. I see a few options: 1) Go for complete feature parity (which we might not want to!) 2) Post a DISCUSS thread asking for lazy consensus on the dev list, to see if others are OK with this change, and proceed accordingly 3) Add this as a new chart, mark the current one as legacy, and live with both in the product until we can make a breaking change (3.0) I'm thinking option 2 might be prudent. I LOVE this PR and would love to see any NVD3 chart die, but I want to make sure we're not pushing any (admittedly small) breaking changes on people without at least some form of official consent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
