eschutho commented on code in PR #22441:
URL: https://github.com/apache/superset/pull/22441#discussion_r1051145536
##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -229,6 +229,9 @@ export function startQuery(query) {
export function querySuccess(query, results) {
return function (dispatch) {
+ if (!results.query) {
Review Comment:
is this line here to prevent an error on line 239? If so, I think it's still
useful to store the query in line 245 and just use optional chaining in case
results.query doesn't exist. `results?.query?.sqlEditorId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
