lyndsiWilliams commented on code in PR #22262:
URL: https://github.com/apache/superset/pull/22262#discussion_r1052348653
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx:
##########
@@ -271,16 +284,33 @@ const DatasetPanel = ({
component = (
<>
<StyledTitle>{COLUMN_TITLE}</StyledTitle>
- <TableContainer>
- <StyledTable
- loading={loading}
- size={TableSize.SMALL}
- columns={tableColumnDefinition}
- data={columnList}
- pageSizeOptions={pageSizeOptions}
- defaultPageSize={10}
- />
- </TableContainer>
+ {tableWithDataset ? (
+ <TableContainerWithBanner>
+ <TableScrollContainer>
+ <Table
+ loading={loading}
+ size={TableSize.SMALL}
+ columns={tableColumnDefinition}
+ data={columnList}
+ pageSizeOptions={pageSizeOptions}
+ defaultPageSize={25}
+ />
+ </TableScrollContainer>
+ </TableContainerWithBanner>
+ ) : (
+ <TableContainerWithoutBanner>
+ <TableScrollContainer>
+ <Table
+ loading={loading}
+ size={TableSize.SMALL}
+ columns={tableColumnDefinition}
+ data={columnList}
+ pageSizeOptions={pageSizeOptions}
+ defaultPageSize={25}
Review Comment:
Can do! Done in [`this
commit`](https://github.com/apache/superset/pull/22262/commits/985f6a919628df1135aa322ff08510b18af6ca3d).
##########
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx:
##########
@@ -95,6 +95,28 @@ const collapseStyles = (theme: SupersetTheme) => css`
}
`;
+const NO_DATABASES_MATCH_TITLE = t('No databases match your search');
+const NO_DATABASES_AVAILABLE_TITLE = t('There are no databases available');
+const MANAGE_YOUR_DATABASES_TEXT = t('Manage your databases');
+const HERE_TEXT = t('here');
+
+export const emptyStateComponent = (emptyResultsWithSearch: boolean) => (
Review Comment:
Good thinking! Done in [`this
commit`](https://github.com/apache/superset/pull/22262/commits/985f6a919628df1135aa322ff08510b18af6ca3d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
