codyml commented on code in PR #22460:
URL: https://github.com/apache/superset/pull/22460#discussion_r1053219674


##########
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts:
##########
@@ -82,7 +82,7 @@ function prepareDashboardFilters(
   }).then(res => {
     const { body } = res;
     const dashboardId = body.result.id;
-    const allFilters: Record<string, any>[] = [];
+    const allFilters: Record<string, unknown>[] = [];

Review Comment:
   Hmm, I tried this but it gave me a "Module '"@superset-ui/core"' has no 
exported member 'Filter'." error.  I also didn't see anywhere else in 
`superset-frontend/cypress-base` that imports from `@superset-ui/core` – do you 
know if these packages are supposed to be isolated for any reason?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to