codyml opened a new pull request, #22516: URL: https://github.com/apache/superset/pull/22516
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR finishes up the work from https://github.com/apache/superset/pull/21823, replacing all uses of icon components from `@ant-design/icons` with uses of Superset's `Icons` component in an effort to make icon use more consistent. Superset's `Icons` component applies slightly different styling rules, so this PR includes some styling tweaks to make icons look the same as before. This PR only replaces icons in `superset-frontend/src`: there are a few direct uses of `@ant-design/icons` in `superset-frontend/packages` and `superset-frontend/plugins`, but because `Icons` lives in `src/components`, replacing these would risk circular dependencies. A follow-up PR could move `Icons` into `@superset-ui/core` and finish the job. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> This is a hopefully comprehensive before/after comparison of every icon affected. The only exception is icons in `src/dashboard/nativeFilters/FilterBar/FilterSets` – I couldn't figure out what this code package does or how to find these icons. I think maybe it's a deprecated feature and the code should be removed? Not sure though. <details> #### `superset-frontend/src/components/Form/LabeledErrorBoundInput` `EyeOutlined` before:  `EyeOutlined` after:  `EyeInvisibleOutlined` before:  `EyeInvisibleOutlined` after:  #### `superset-frontend/src/components/Select/utils` `DownOutlined` before: <img width="1165" alt="DownOutlined before" src="https://user-images.githubusercontent.com/13007381/209236869-d8d4c519-521a-4c27-bc95-5fe39d2b5548.png";> `DownOutlined` after: <img width="1165" alt="DownOutlined after" src="https://user-images.githubusercontent.com/13007381/209236890-ccecae91-6ddf-4b73-abd0-80f865993d93.png";> `SearchOutlined` before: <img width="1165" alt="SearchOutlined before" src="https://user-images.githubusercontent.com/13007381/209236906-01a63265-de44-4501-88fa-91cc23b59235.png";> `SearchOutlined` after: <img width="1165" alt="SearchOutlined after" src="https://user-images.githubusercontent.com/13007381/209236934-a729b4f3-a495-47b4-9b14-e032a337a801.png";> #### `superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index` Before:  After:  #### `superset-frontend/src/dashboard/components/FiltersBadge/FilterIndicator/index` Before:  After:  #### `superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index` Non-pivot before:  Non-pivot after:  Pivot before:  Pivot after:  #### `superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/EncryptedField` Before:  After:  #### `superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/TableCatalog` Before:  After:  </details> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Check that all of the icons listed in the above section look the same as before. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/13007381/209236869-d8d4c519-521a-4c27-bc95-5fe39d2b5548.png"](https://user-images.githubusercontent.com/13007381/209236869-d8d4c519-521a-4c27-bc95-5fe39d2b5548.png"){kind=link}
![https://user-images.githubusercontent.com/13007381/209236890-ccecae91-6ddf-4b73-abd0-80f865993d93.png"](https://user-images.githubusercontent.com/13007381/209236890-ccecae91-6ddf-4b73-abd0-80f865993d93.png"){kind=link}
![https://user-images.githubusercontent.com/13007381/209236906-01a63265-de44-4501-88fa-91cc23b59235.png"](https://user-images.githubusercontent.com/13007381/209236906-01a63265-de44-4501-88fa-91cc23b59235.png"){kind=link}
![https://user-images.githubusercontent.com/13007381/209236934-a729b4f3-a495-47b4-9b14-e032a337a801.png"](https://user-images.githubusercontent.com/13007381/209236934-a729b4f3-a495-47b4-9b14-e032a337a801.png"){kind=link}
