villebro opened a new pull request, #22566:
URL: https://github.com/apache/superset/pull/22566

   ### SUMMARY
   Currently the View 
   
   ### AFTER
   Now when a user that doesn't have the `sql_lab` role will no longer see the 
"View in SQL Lab" menu item:
   
   
![image](https://user-images.githubusercontent.com/33317356/210236216-67179de5-1e3b-45d7-9d07-9a34e512f5b6.png)
   
   For admin and users with `sql_lab` role the menu is unchanged:
   
   
![image](https://user-images.githubusercontent.com/33317356/210236242-91967cc4-371b-4277-9266-28848034bd8f.png)
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to