SamraHanifCareem opened a new pull request, #22587:
URL: https://github.com/apache/superset/pull/22587
**SUMMARY**
Adding CSV File Validations such as:
- Max File Size
- Rows to Read
**BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF**
<img width="1779" alt="Screenshot 2023-01-04 at 3 18 52 PM"
src="https://user-images.githubusercontent.com/106157603/210534636-94221e85-b0c1-42fc-ad4d-3e0df76524ea.png";>
**TESTING INSTRUCTIONS**
- Configure the following keys in config.py according to the requirements:
1. CSV_MAX_SIZES
2. CSV_MAX_ROWS
3. CSV_MIN_ROWS
- Route to Databases Screen
- Upload CSV File
**ADDITIONAL INFORMATION**
- [ ] Has associated issue:
- [x] Required config changes : CSV_MAX_SIZES, CSV_MAX_ROWS, CSV_MIN_ROWS
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
https://github.com/apache/superset/issues/13351)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/106157603/210534636-94221e85-b0c1-42fc-ad4d-3e0df76524ea.png"](https://user-images.githubusercontent.com/106157603/210534636-94221e85-b0c1-42fc-ad4d-3e0df76524ea.png"){kind=link}