eric-briscoe commented on PR #22502: URL: https://github.com/apache/superset/pull/22502#issuecomment-1378206366
> I'm seeing 2 problems: > > 1. There's "0" added at the end of `Scope` and `Dependent on` rows in filter cards > 2. I see some flaky behaviour in filter cards. I set `test2` to be dependent on `test, test3, test4, test5`. The expected behaviour would be to display `test, test... +2`. You can see at the recording that it sometimes displays `test, test... +1` or `test, test3, ... 0`, neither of which is correct > > Screen.Recording.2022-12-22.at.18.20.32.mov @kgabryje thank you for catching this. It took a while to track down the root cause of this. The behavior has been addressed in recent commit. The inconsistent behavior had to do with timing on antd popover setting CSS value of display: hidden to the popover component. While this container has the hidden value all children in DOM will report 0 widths. Because the CSS value gets set async from our components lifecycle it created odd race conditions and miscalculations. The current version should show correct and stable results. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
