[GitHub] [superset] justinpark opened a new pull request, #22695: fix(sqllab): Invalid schema fetch for deprecated value @justinpark

[GitBox]

justinpark opened a new pull request, #22695:
URL: https://github.com/apache/superset/pull/22695

   ### SUMMARY
   When a selected schema option in a old saved tab has been deprecated, it 
would fail to query since the selected schema is no longer existed. 
   This commit adds the validation logic for the current selected schema option 
and then discard the schema option if no longer existed.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   After:
   
   <img width="398" alt="Screenshot_2023-01-11_at_3_14_23_PM" 
src="https://user-images.githubusercontent.com/1392866/211938466-223b5473-be41-4de1-89e4-6cc19021afc1.png";>
   
   No error thrown
   
   Before:
   
   <img width="415" alt="Screenshot_2023-01-09_at_3_55_57_PM" 
src="https://user-images.githubusercontent.com/1392866/211938201-af50da2a-3a5b-4fec-b479-e15e98eb2060.png";>
   
   <img width="900" alt="Superset-2" 
src="https://user-images.githubusercontent.com/1392866/211938150-e2d3d9a7-1566-4787-ab9e-cde8a645de16.png";>
   
   
   <img width="746" alt="superset-goalie_-_Airbnb_-_Slack" 
src="https://user-images.githubusercontent.com/1392866/211938400-bfb1560a-272e-4ea5-b450-261e7ab42b00.png";>
   
   
   ### TESTING INSTRUCTIONS
   
   - Select a schema from the list and then close
   - delete the above selected schema
   - reopen the sqllab and check the error
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org