Antonio-RiveroMartnez commented on code in PR #22764:
URL: https://github.com/apache/superset/pull/22764#discussion_r1073023404
##########
superset/extensions/ssh.py:
##########
@@ -63,8 +63,8 @@ def create_tunnel(
elif ssh_tunnel.private_key:
private_key_file = StringIO(ssh_tunnel.private_key)
private_key = RSAKey.from_private_key(private_key_file)
- params["private_key"] = private_key
- params["private_key_password"] = ssh_tunnel.private_key_password
+ params["ssh_pkey"] = private_key
+ params["ssh_private_key_password"] =
ssh_tunnel.private_key_password
Review Comment:
Oh! I was reading the docs here: https://sshtunnel.readthedocs.io/en/latest/
thanks!
Also, not a blocker for these changes, but probably worth mentioning we
should make sure that when updating a tunnel, if we send a `password` or
`private_key/private_key_password`, we remove the other login method from the
tunnel (the UI is doing it already), otherwise, it will get into the `if` all
the time if both are present, even if `password` is not the latest login method
of the tunnel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
