cccs-RyanK opened a new pull request, #20876: URL: https://github.com/apache/superset/pull/20876
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This work was done by [@cccs-nik](https://github.com/cccs-nik) on our own fork of superset. Currently, there exists tagging for dashboards, charts, and saved queries in the backend. This PR introduces Tagging to the front-end and allows users to view and edit tags in the UI. Feedback is greatly appreciated! The following are some features introduced: - Tags can be seen and are searchable in the list view for dashboards, charts and saved queries. Tags can be added via the "edit properties" modal for dashboards and charts, but there is currently no way to add tags to saved queries. - Clicking on a tag will take the user to a new page that displays all objects with that tag. - Tags are automatically applied to all objects that contain the type of an object and the owner of the object, but only "custom" type tags are displayed in the UI. The future work for this will be to add tags for saved queries somewhere in the UI and to add tagging for datasets to both the frontend and the backend. NOTE: currently working on adding some integration tests for the tags api changes and they will shortly be added ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Some examples for tagging dashboards Dashboard List  Dashboard Header  Edit Properties for Dashboard  Tags View (endpoint: /superset/tags/?tags=[tag_name])  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Set feature flag TAGGING_SYSTEM to true in superset/config.py - navigate to the edit properties modal for either charts or dashboards to add tags - view tags from the lists or headers for dashboards or charts. - click on tags or navigate to the 'Tags' tab to search objects by tags. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: - [x] Required feature flags: `TAGGING_SYSTEM` - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
