john-bodley commented on PR #22794: URL: https://github.com/apache/superset/pull/22794#issuecomment-1399086653
@villebro regarding your comment, > LGTM. In the long term it would be nice to push this fix upstream, as I'm sure this causes confusion wherever PyHive is used. I completely agree—I'm generally a fan of the shift-left mentality. I looked into at some stage but there's also a breaking change in terms of how PyHive doesn't adhere to the SQLAlchemy specification, i.e., if the schema is undefined then it fetches all the tables and views for the entire database as opposed to the default schema/namespace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
