eschutho commented on PR #22325: URL: https://github.com/apache/superset/pull/22325#issuecomment-1400716411
Thank you @mayurnewase. If you want to put up a new pr, I would suggest a few things to make it backward compatible: 1) deprecate, don't remove old views. Change the client side to use react but still keep the old views for backward compatibility. You can even change the client side route if you need to. 2) Instead of changing the naming on configs, you can add new ones and deprecate the old ones, but make sure that wither will work for now. 3) Same with permission names, add new ones and deprecate old ones, making sure that both still work. > @eschutho Maybe it's better to add a feature flag for the new breaking changes of RLS instead of reverting the PR? I don't believe a feature flag specifically would work in this case, but I've outlined some other options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
