rusackas commented on code in PR #22772:
URL: https://github.com/apache/superset/pull/22772#discussion_r1086906988
##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -1419,7 +1419,8 @@ export function popDatasourceQuery(datasourceKey, sql) {
.then(({ json }) =>
dispatch(
addQueryEditor({
- name: `Query ${json.result.name}`,
+ // eslint-disable-next-line prefer-template
+ title: t('Query') + ` ${json.result.name}`,
Review Comment:
Same here, might as well lean into the template strings unless there's a
reason not to.
```suggestion
title: `${t('Query')} ${json.result.name}`,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
