kgabryje opened a new pull request, #22886:
URL: https://github.com/apache/superset/pull/22886

   
   ### SUMMARY
   This PR adds cross filtering functionality to Echarts Graph and World Map.
   Additionally, before user could only click on the edge of Graph chart to 
open a context menu for Drill By. This PR enables also clicking on nodes.
   
   Known issue - In graph chart, the selection after clicking gets cancelled 
after hovering on any other node or edge. This has yet to be fixed
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
https://user-images.githubusercontent.com/15073128/215102016-5e2ed689-fae5-4355-9f3c-a9c2a4069400.mov
   
   
https://user-images.githubusercontent.com/15073128/215102065-9e5dfe3f-4148-491a-94c5-ea66dda942b3.mov
   
   
   ### TESTING INSTRUCTIONS
   1. Add Graph and World Map to a dashboard
   2. If dashboard has cross filtering enabled, clicking on a country (in World 
Map) or on a node (in Graph) should enable cross filtering.
   3. If dashboard has cross filtering disabled, clicking shouldn't do anything
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to