kgabryje opened a new pull request, #23000: URL: https://github.com/apache/superset/pull/23000
### SUMMARY When user had `UX_BETA` feature flag enabled, drag and dropping a column into Metrics control opened the metrics popover with aggregate function pre-filled. However, due to faulty logic, the `Save` button was disabled despite all fields being filled correctly. Now the Save button is enabled as expected. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://user-images.githubusercontent.com/15073128/216995144-be821bb6-eed4-4207-807f-1f0679d8d8ca.mov After: https://user-images.githubusercontent.com/15073128/216995230-87b4f3ac-bd67-47f9-840e-934a20b620ab.mov ### TESTING INSTRUCTIONS 1. Enable `UX_BETA` feature flag 2. Drag a column to Metrics control 3. Verify that the Column and Aggregate fields are filled and Save button is enabled ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
