Antonio-RiveroMartnez opened a new pull request, #23099:
URL: https://github.com/apache/superset/pull/23099

   ### SUMMARY
   
   We are now enabling users to export databases that have SSHTunnels related 
to them. The exported ssh_tunnel will get included in the `database` `yaml` 
file and will have the used login method (`password` or `private_key + 
private_key_password`) with masked values.
   Then when user tries to import such databases (or any 
dashboard/chart/dataset/savedquery), the modal will ask the user to enter such 
credentials.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   1. Export a DB with SSH Tunnel
   2. The exported file should include the `ssh_tunnel` with masked login method
   3. Try importing a DB that has `ssh_tunnel` in it
   4. The modal should ask you to enter the credentials (`password` OR 
`private_key + private_key_password`)
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [X] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to