hughhhh commented on code in PR #20876: URL: https://github.com/apache/superset/pull/20876#discussion_r1110230166
########## superset/tags/api.py: ########## @@ -0,0 +1,386 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import logging +from typing import Any + +from flask import request, Response +from flask_appbuilder.api import expose, protect, rison, safe +from flask_appbuilder.models.sqla.interface import SQLAInterface + +from superset.constants import MODEL_API_RW_METHOD_PERMISSION_MAP, RouteMethod +from superset.extensions import event_logger +from superset.tags.commands.create import CreateCustomTagCommand +from superset.tags.commands.delete import DeleteTaggedObjectCommand, DeleteTagsCommand +from superset.tags.commands.exceptions import ( + TagCreateFailedError, + TagDeleteFailedError, + TaggedObjectDeleteFailedError, + TaggedObjectNotFoundError, + TagInvalidError, + TagNotFoundError, +) +from superset.tags.dao import TagDAO +from superset.tags.models import ObjectTypes, Tag +from superset.tags.schemas import ( + delete_tags_schema, + openapi_spec_methods_override, + TaggedObjectEntityResponseSchema, + TagGetResponseSchema, + TagPostSchema, +) +from superset.views.base_api import ( + BaseSupersetModelRestApi, + RelatedFieldFilter, + statsd_metrics, +) +from superset.views.filters import BaseFilterRelatedUsers, FilterRelatedOwners + +logger = logging.getLogger(__name__) + + +class TagRestApi(BaseSupersetModelRestApi): + datamodel = SQLAInterface(Tag) + include_route_methods = RouteMethod.REST_MODEL_VIEW_CRUD_SET | { + RouteMethod.RELATED, + "bulk_delete", + "get_objects", + "get_all_objects", + "add_objects", + "delete_object", + } + + resource_name = "tag" Review Comment: can we change this to be plural `tags` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
