betodealmeida commented on code in PR #23131: URL: https://github.com/apache/superset/pull/23131#discussion_r1113458696
########## docs/docs/installation/setup-ssh-tunneling.mdx: ########## @@ -0,0 +1,21 @@ +--- +title: Setup SSH Tunneling +hide_title: true +sidebar_position: 13 +version: 1 +--- + +## SSH Tunneling + +1. Turn on feature flag + - Change (this value)[https://github.com/apache/superset/blob/master/superset/config.py#L489] to `True` Review Comment: This link is going to be broken very quickly. You can use a link to a specific revision: https://github.com/apache/superset/blob/eb8386e3f0647df6d1bbde8b42073850796cc16f/superset/config.py#L489 But even better would be also including what feature flag should be changed: ```suggestion - Change (`SSH_TUNNELING`)[https://github.com/apache/superset/blob/eb8386e3f0647df6d1bbde8b42073850796cc16f/superset/config.py#L489] to `True` ``` ########## docs/docs/installation/setup-ssh-tunneling.mdx: ########## @@ -0,0 +1,21 @@ +--- +title: Setup SSH Tunneling +hide_title: true +sidebar_position: 13 +version: 1 +--- + +## SSH Tunneling + +1. Turn on feature flag + - Change (this value)[https://github.com/apache/superset/blob/master/superset/config.py#L489] to `True` + - If you want to add more security when establish the tunnel we allow users to overwrite the `SSHTunnelManager` class (here)[https://github.com/apache/superset/blob/master/superset/config.py#L507] Review Comment: ```suggestion - If you want to add more security when establishing the tunnel we allow users to overwrite the `SSHTunnelManager` class (here)[https://github.com/apache/superset/blob/master/superset/config.py#L507] ``` Same here, link to a specific SHA like I did above. ########## docs/docs/installation/setup-ssh-tunneling.mdx: ########## @@ -0,0 +1,21 @@ +--- +title: Setup SSH Tunneling +hide_title: true +sidebar_position: 13 +version: 1 +--- + +## SSH Tunneling + +1. Turn on feature flag + - Change (this value)[https://github.com/apache/superset/blob/master/superset/config.py#L489] to `True` + - If you want to add more security when establish the tunnel we allow users to overwrite the `SSHTunnelManager` class (here)[https://github.com/apache/superset/blob/master/superset/config.py#L507] + - You can also set the (`SSH_TUNNEL_LOCAL_BIND_ADDRESS`)[https://github.com/apache/superset/blob/master/superset/config.py#L508] this the host address where the tunnel will be accessible on your VPC + +2. Create database w/ ssh tunnel enabled + - With the feature flag enabled you should now see ssh tunnel toggle + - Click the toggle to enables ssh tunneling and add your credentials accordingly. + - Superset allows for 2 different type authenticaion (Basic + Private Key). These credentials should come from your service provider. + +3. Verify data is flowing + - After goto SQL Lab, and write a query to verify data is properly flowing. Review Comment: ```suggestion - Once SSH tunneling has been enabled, go to SQL Lab and write a query to verify data is properly flowing. ``` ########## docs/docs/installation/setup-ssh-tunneling.mdx: ########## @@ -0,0 +1,21 @@ +--- +title: Setup SSH Tunneling +hide_title: true +sidebar_position: 13 +version: 1 +--- + +## SSH Tunneling + +1. Turn on feature flag + - Change (this value)[https://github.com/apache/superset/blob/master/superset/config.py#L489] to `True` + - If you want to add more security when establish the tunnel we allow users to overwrite the `SSHTunnelManager` class (here)[https://github.com/apache/superset/blob/master/superset/config.py#L507] + - You can also set the (`SSH_TUNNEL_LOCAL_BIND_ADDRESS`)[https://github.com/apache/superset/blob/master/superset/config.py#L508] this the host address where the tunnel will be accessible on your VPC + +2. Create database w/ ssh tunnel enabled + - With the feature flag enabled you should now see ssh tunnel toggle Review Comment: ```suggestion - With the feature flag enabled you should now see ssh tunnel toggle. ``` ########## docs/docs/installation/setup-ssh-tunneling.mdx: ########## @@ -0,0 +1,21 @@ +--- +title: Setup SSH Tunneling +hide_title: true +sidebar_position: 13 +version: 1 +--- + +## SSH Tunneling + +1. Turn on feature flag + - Change (this value)[https://github.com/apache/superset/blob/master/superset/config.py#L489] to `True` + - If you want to add more security when establish the tunnel we allow users to overwrite the `SSHTunnelManager` class (here)[https://github.com/apache/superset/blob/master/superset/config.py#L507] + - You can also set the (`SSH_TUNNEL_LOCAL_BIND_ADDRESS`)[https://github.com/apache/superset/blob/master/superset/config.py#L508] this the host address where the tunnel will be accessible on your VPC Review Comment: Ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
