[GitHub] [superset] kgabryje commented on pull request #23138: feat: Cross Filters in FilterBar

[via GitHub]

kgabryje commented on PR #23138:
URL: https://github.com/apache/superset/pull/23138#issuecomment-1439770083

   A few visual issues:
   
   1. Tag's X button is not centered.
   2. Tag's outline is different colour than in designs
   <img width="326" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220590393-703cfb9a-0b2c-4453-b383-ef441c7635b7.png";>
   <img width="420" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220590445-ecffab08-acd5-474f-ba00-bce8d58f0c20.png";>
   
   3. Horizontal line between cross-filters and native filters is missing in 
vertical filter bar
   <img width="607" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220590590-ee13653a-dbc7-4db8-955d-794424a2ef37.png";>
   
   4. Spacing between title and icon is 8px, should be 4 
   <img width="113" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220591551-524ef612-33f8-412b-be3c-c8a197603220.png";>
   
   5. Separator line in horizontal bar is too thick - should be 1px 
   <img width="143" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220591678-d538535b-95c5-4fb8-bf8b-42821b9daa5f.png";>
   
   6. Top margin in overflow dropdown is too big 
   <img width="430" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220591905-e63ba40c-9cf0-4fd2-a23d-3455e27fa828.png";>
   
   7. Separator line in overflow dropdown is too thick 
   <img width="379" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220592147-cca6e59a-3078-4899-a2d4-b93279ebf5e7.png";>
   
   8. I think it wasn't included in designs, but "Filters out of scope" should 
probably be the same font size as "Cross-filters" collapsible title for 
consistency 
   <img width="378" alt="image" 
src="https://user-images.githubusercontent.com/15073128/220592433-a513bd6e-6229-4e78-989a-1e6b466a8734.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org