[GitHub] [superset] kgabryje opened a new pull request, #23238: fix(dashboard): Charts crashing when cross filter on adhoc column is applied

[via GitHub]

kgabryje opened a new pull request, #23238:
URL: https://github.com/apache/superset/pull/23238

   
   ### SUMMARY
   When there are charts using different datasets in a dashboard and a cross 
filter is applied on an adhoc column, the charts that use different dataset 
than the origin chart are crashing with a db error.
   This PR fixes that by excluding filters based on an incompatible adhoc 
column from the query.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   <img width="1728" alt="image" 
src="https://user-images.githubusercontent.com/15073128/221936633-0af12308-5dc3-4e8f-ae63-acdb6addcfee.png";>
   
   After:
   
   <img width="1728" alt="image" 
src="https://user-images.githubusercontent.com/15073128/221937754-bfa8a068-1d0c-4bf7-a1d0-fb14dba83c04.png";>
   
   ### TESTING INSTRUCTIONS
   1. Create a chart that is grouped by an adhoc column (with sql expression) 
and add it to a dashboard
   2. Add another chart to a dashboard, which should use a different dataset 
than the first chart
   3. Apply a cross filter by clicking on a series related to the adhoc column 
in the first chart
   4. Verify that the second chart doesn't crash and is not filtered by the 
cross filter
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org