eschutho commented on code in PR #23114:
URL: https://github.com/apache/superset/pull/23114#discussion_r1122494377
##########
superset/utils/screenshots.py:
##########
@@ -204,41 +219,30 @@ class ChartScreenshot(BaseScreenshot):
thumbnail_type: str = "chart"
element: str = "chart-container"
- def __init__(
- self,
- url: str,
- digest: str,
- window_size: Optional[WindowSize] = None,
- thumb_size: Optional[WindowSize] = None,
- ):
- # Chart reports are in standalone="true" mode
+ def __init__(self, url: str, digest: str, *args: ScreenshotDetails):
Review Comment:
@betodealmeida what do you think of this as a way to resolve the
too-many-arguments linting error? I see that we're ignoring it in a lot of
places, but I'd like to find a solution that we can use as a pattern for
bundling up extra args/kwargs, and wanted to get your thoughts on this
approach. (also see line 228 below). Also note that all of the
ScreenshotDetails properties are optional, too. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
