geido commented on code in PR #23216: URL: https://github.com/apache/superset/pull/23216#discussion_r1129729590
########## superset-frontend/src/assets/images/icons/filter.svg: ########## @@ -16,6 +16,7 @@ KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg";> Review Comment: The filter_small icon has a lot of padding around and it does not respect the sizes being given through the Icons component. In order to get a size M you would need to give it a XL. I believe the reason for that is because indeed it was meant to be "small". For that reason, I replaced the actual filter icon with the one from our design files as I believe it should be the same everywhere -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
